Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): Add factory method for Notification DTO #531

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

FelixTing
Copy link
Member

Signed-off-by: Felix Ting felix@iotechsys.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #530

What is the new behavior?

Added factory method for Notification DTO.

Close #530

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

@codecov-io
Copy link

Codecov Report

Merging #531 (5dcc54c) into master (860d36c) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   56.49%   56.63%   +0.13%     
==========================================
  Files         119      119              
  Lines        3556     3567      +11     
==========================================
+ Hits         2009     2020      +11     
  Misses       1357     1357              
  Partials      190      190              
Impacted Files Coverage Δ
v2/dtos/notification.go 25.58% <100.00%> (+25.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860d36c...5dcc54c. Read the comment docs.

v2/dtos/notification.go Outdated Show resolved Hide resolved
Signed-off-by: Felix Ting <felix@iotechsys.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 6e37081 into edgexfoundry:master Mar 4, 2021
@FelixTing FelixTing deleted the issue-530 branch March 5, 2021 01:52
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2] Add factory method for Notification DTO
3 participants