Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Constants for configuration's map key #521

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

weichou1229
Copy link
Member

Signed-off-by: weichou weichou1229@gmail.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #449

What is the new behavior?

Create Primary and Password for configuration's map key

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Create Primary and Password for configuration's map key

Close edgexfoundry#449

Signed-off-by: weichou <weichou1229@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #521 (7342969) into master (caf1e88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   56.40%   56.40%           
=======================================
  Files         119      119           
  Lines        3526     3526           
=======================================
  Hits         1989     1989           
  Misses       1369     1369           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf1e88...7342969. Read the comment docs.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 82d3046 into edgexfoundry:master Feb 25, 2021
@weichou1229 weichou1229 deleted the issue-449 branch July 13, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants