refactor(meta): V2 Device OperatingState value change #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed in the Device WG meeting on 5th-Oct-2020, the OperatingState field in DeviceService model is not used. Its status should be monitored via health check like other services in general, so it is not necessary to manage it in core-metadata. Fix edgexfoundry#319 Signed-off-by: weichou <weichou1229@gmail.com>
Fix edgexfoundry#318 Signed-off-by: weichou <weichou1229@gmail.com>
Discussed in the Device WG meeting on 5th-Oct-2020, we would like to change the enumeration value of OperatingState from Enabled/Disabled to Up/Down/Unknown. Fix edgexfoundry#318 Signed-off-by: weichou <weichou1229@gmail.com>
weichou1229
force-pushed
the
issue-318
branch
from
15a3b03
to
f86ad7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #318
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #318
What is the new behavior?
V2 Device OperatingState value change the enumeration value of OperatingState from Enabled/Disabled to Up/Down/Unknown
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
This PR is based on the #384