Make device client compliant with edgex-go implementation #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s update Device admin and operating status update implementation have been changed in edgex-go so that the status data is sent in the request body instead of being part of the URL (see edgexfoundry/edgex-go#1361) But go-mod-core-contracts wasn't updated accordingly. This PR makes go-mod-core-contracts Device interface complient with the implementation within edgex-go. Fix: edgexfoundry#272 Signed-off-by: Diana Atanasova <dianaa@vmware.com>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#126 PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Device admin and operating status update implementation have been changed
in edgex-go so that the status data is sent in the request body instead of being part of the URL
(see edgexfoundry/edgex-go#1361)
But go-mod-core-contracts wasn't updated accordingly.
So if you try to update admin/operating device state using Device client interface an error "404 page not found" is returned , because endpoint with such path does not exists
Issue Number:
#272
What is the new behavior?
This PR makes go-mod-core-contracts Device interface compliant with the
implementation within edgex-go.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information
Signed-off-by: Diana Atanasova dianaa@vmware.com