feat: add CBOR support in EventClient for binary reading #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudxxx8
requested changes
Mar 17, 2021
v2/clients/http/utils/common.go
Outdated
| jsonEncodedData, err := json.Marshal(data) | ||
| if err != nil { | ||
| return nil, errors.NewCommonEdgeX(errors.KindContractInvalid, "failed to encode input data to JSON", err) | ||
| func createRequestWithRawData(ctx context.Context, httpMethod string, url string, data interface{}, cborEncoding bool) (*http.Request, errors.EdgeX) { |
There was a problem hiding this comment.
don't use bool because we might have other encoding in the future.
please use string and leverage clients.ContentTypeCBOR / clients.ContentTypeJSON.
cloudxxx8
requested changes
Mar 18, 2021
Signed-off-by: Chris Hung <chris@iotechsys.com>
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 56.23% 56.17% -0.07%
==========================================
Files 119 119
Lines 3551 3557 +6
==========================================
+ Hits 1997 1998 +1
- Misses 1357 1361 +4
- Partials 197 198 +1
Continue to review full report at Codecov.
|
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Hung chris@iotechsys.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: fix #543
What is the new behavior?
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information