Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] Add CBOR support in the Event client library #543

Closed
cloudxxx8 opened this issue Mar 11, 2021 · 1 comment · Fixed by #550
Closed

[V2] Add CBOR support in the Event client library #543

cloudxxx8 opened this issue Mar 11, 2021 · 1 comment · Fixed by #550
Assignees
@chr1shung
Labels
2-medium priority denoting issues with cross-cutting project impact enhancement New feature or request ireland

Comments

@cloudxxx8
Copy link
Member

The logic of handling CBOR Event should be moved from device-sdk-go to contract client library.
@cloudxxx8 cloudxxx8 added enhancement New feature or request 2-medium priority denoting issues with cross-cutting project impact ireland labels Mar 11, 2021
@lenny-goodell
Copy link
Member

Also, please add use of experimental environment variable EDGEX_ENCODE_ALL_EVENTS_CBOR that if true all events are encoded as CBOR, not just ones with binary readings . Default is false if environment variable not explicitly set to true .

@chr1shung chr1shung mentioned this issue Mar 17, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chr1shung chr1shung

Labels
2-medium priority denoting issues with cross-cutting project impact enhancement New feature or request ireland
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add CBOR support in EventClient for binary reading
3 participants
@cloudxxx8 @chr1shung @lenny-goodell