Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new env to support -o flag #749

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Aug 20, 2024

Since the flag is hard to use for the container environment, create a new env EDGEX_OVERWRITE_CONFIG to provide the same feature support as -o/--overwrite flag.

Close #747

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  1. Start the EdgeX with the default configs and config provider.
  2. Modify the docker-compose file with the environment variable EDGEX_OVERWRITE_CONFIG: true and set other environment variable to change the private or common config.
  3. Check the config provider if the new change of the environment variable overwrite is pushed.

Since the flag is hard to use for the container environment, create a
new env EDGEX_OVERWRITE_CONFIG to provide the same feature support as
-o/--overwrite flag.

Close edgexfoundry#747

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlinGuan jinlinGuan merged commit 6f7163b into edgexfoundry:main Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to make the environment variable config override take priority
2 participants