Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Core Keeper changes based on OpenZiti changes #723

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jackchenjc
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Jack Chen <jack@iotechsys.com>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.09%. Comparing base (7073930) to head (614d19a).

Files Patch % Lines
bootstrap/registration/registry.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   55.12%   55.09%   -0.03%     
==========================================
  Files          32       32              
  Lines        2705     2706       +1     
==========================================
  Hits         1491     1491              
- Misses       1112     1113       +1     
  Partials      102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit f57a467 into edgexfoundry:main Jul 2, 2024
3 checks passed
@@ -120,6 +121,10 @@ func RunAndReturnWaitGroup(
if err != nil {
fatalError(fmt.Errorf("failed to create SecretProvider: %s", err.Error()), lc)
}

// Bypass the zero trust zitidfied transport for Core Keeper Configuration client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloudxxx8 / @jackchenjc, this has an unintentional side-effect of breaking device-virtual. Strictly speaking this also should not be necessary as the zitified transport is configured with fallback, meaning if it can't dial a zitified endpoint, it should fallback to using an underlay dialer.

I'm sure this was a problem somewhere/somehow, but can I work with you to figure out why??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants