feat(scheduler): Implement POST /intervalaction V2 API #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold this PR according to the discussion of the PR edgexfoundry/go-mod-core-contracts#518 (comment) |
lenny-goodell
requested changes
Feb 24, 2021
internal/support/scheduler/v2/controller/http/intervalaction_test.go
Outdated
Show resolved
Hide resolved
|
This PR should hold until edgexfoundry/go-mod-core-contracts#536 merged. |
lenny-goodell
requested changes
Mar 8, 2021
Implement the V2 API according to the swagger doc https://app.swaggerhub.com/apis-docs/EdgeXFoundry1/support-scheduler/2.x#/default/post_intervalaction Close #3187 Signed-off-by: weichou <weichou1229@gmail.com>
Close #3187 Signed-off-by: weichou <weichou1229@gmail.com>
- Upgrade core-contract lib to latest version - Add the description to clarify that id or name is an either requirement, not both Close #3187 Signed-off-by: weichou <weichou1229@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3190 +/- ##
==========================================
+ Coverage 41.81% 41.87% +0.06%
==========================================
Files 177 179 +2
Lines 15180 15252 +72
==========================================
+ Hits 6347 6387 +40
- Misses 8460 8492 +32
Partials 373 373
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3187
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #3187
What is the new behavior?
Implement the V2 API according to the swagger doc https://app.swaggerhub.com/apis-docs/EdgeXFoundry1/support-scheduler/2.x#/default/post_intervalaction
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information