Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(security): Enable Vault's Consul secrets engine #3179

Merged
merged 3 commits into from
Feb 22, 2021
Merged

feat(security): Enable Vault's Consul secrets engine #3179

merged 3 commits into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. feat(security): Enable Vault's consul secrets engine 

    - Add Secret Engine Enabler so that it can be re-used for both of Consul and KV secrets engines
- Hookup the code in secretstore-setup so that both KV and Consul secret engines are enabled

Closes: edgexfoundry#3154

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
    @jim-wang-intel
    jim-wang-intel committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    5adc20e View commit details
    Browse the repository at this point in the history

  2. refactor: move secretsengine's enabler to secretstore-setup and resov… 

    …led merging conflicts

Refator to move enabler to secretstore-setup in edgex-go
Rebased and resolved the merging conflicts
Use the secret client from go-mod-secret

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
    @jim-wang-intel
    jim-wang-intel committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    4cb289a View commit details
    Browse the repository at this point in the history

  3. fix: address Lenny's PR feedback 

    Address PR comments

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
    @jim-wang-intel
    jim-wang-intel committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    e54cfd9 View commit details
    Browse the repository at this point in the history