Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): Refactor device service update operation to DBClient #3066

Merged
merged 1 commit into from
Jan 22, 2021
Merged

refactor(meta): Refactor device service update operation to DBClient #3066

merged 1 commit into from
Jan 22, 2021

Conversation

weichou1229
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #3043

What is the new behavior?

Refactor update operation to DBClient because deleting and adding to update a record only used for RedisDB.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #3066 (6b9e3f1) into master (001da8f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
- Coverage   40.77%   40.71%   -0.06%     
==========================================
  Files         168      168              
  Lines       14071    14090      +19     
==========================================
  Hits         5737     5737              
- Misses       8007     8026      +19     
  Partials      327      327              
Impacted Files Coverage Δ
internal/pkg/v2/infrastructure/redis/client.go 0.00% <0.00%> (ø)
...rnal/pkg/v2/infrastructure/redis/device_service.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001da8f...6b9e3f1. Read the comment docs.

@cloudxxx8
Copy link
Member

there is a conflict. please help rebase

Refactor update operation to DBClient because deleting and adding to update a record only used for RedisDB.

Signed-off-by: weichou <weichou1229@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@weichou1229
Copy link
Member Author

Conflict resolved.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 5d6d036 into edgexfoundry:master Jan 22, 2021
@weichou1229 weichou1229 deleted the issue-3043-device-service branch July 15, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants