Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(security): Remove Vault dependency on Consul by using file backend #2886

Merged
merged 2 commits into from
Dec 10, 2020
Merged

feat(security): Remove Vault dependency on Consul by using file backend #2886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560fc2a
feat(security): Remove Vault dependency on Consul by using file backe…
jim-wang-intel Nov 18, 2020
565a8fe
feat(security): Address PR feedback on /vault/file
jim-wang-intel Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions cmd/security-secrets-setup/start_vault.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,9 @@ listener "tcp" {
tls_disable = "1"
cluster_address = "edgex-vault:8201"
}
backend "consul" {
path = "vault/"
address = "edgex-core-consul:8500"
scheme = "http"
redirect_addr = "http://edgex-vault:8200"
cluster_addr = "http://edgex-vault:8201"
}
backend "file" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this go once this service is removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will go to "bootstrapper" i guess and this one is taking the baby step. so in terms of removing is beyond the scope of this related issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue #2882

Copy link
Collaborator

@bnevis-i bnevis-i Dec 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes straight into the docker-compose file as static configuration via env var (TLS was generating the variable parameters)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also check to see if the snap depends on this script to generate the config file, or uses something else.

Copy link
Contributor Author

@jim-wang-intel jim-wang-intel Dec 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenny-intel please suggest a change. i do not know what you want me to do.

path = "/vault/file"
}
default_lease_ttl = "168h"
max_lease_ttl = "720h"
'
Expand Down