feat: Add persisting of new Tags property on V1 & V2 Event models for Redis #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
tonyespy,
jpwhitemn,
cloudxxx8 and
lindseysimple
|
We updated DeviceClient in edgexfoundry/go-mod-core-contracts#273 , so the mocks.DeviceClient needs to be updated to pass the unit test |
Addressing this with separate issue and PR. |
… Redis closes edgexfoundry#2668 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
tags-redis
branch
from
4391f1e
to
062096e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
make testhas completed successfullyPR Type
What kind of change does this PR introduce?
What is the current behavior?
New Tags property on V1 & V2 models not persisted to Redis DB
Issue Number: #2668
What is the new behavior?
New Tags property on V1 & V2 models is now persisted to Redis DB
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information