refactor: Removed client monitoring #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
tonyespy,
jpwhitemn,
cloudxxx8,
bnevis-i,
rsdmike,
jim-wang-intel and
charles-knox-intel
|
Does the affect consul's reporting whether the service is healthy or not? |
Nope. Just removes services asking Consul for the current URL for a dependent service. |
closes edgexfoundry#2594 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
monitoring
branch
from
93bef34
to
2ea1893
Compare
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
==========================================
+ Coverage 38.87% 38.97% +0.09%
==========================================
Files 145 145
Lines 12826 12671 -155
==========================================
- Hits 4986 4938 -48
+ Misses 7560 7459 -101
+ Partials 280 274 -6
Continue to review full report at Codecov.
|
brian-intel
approved these changes
Jun 23, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1723 PR Checklist
Please check if your PR fulfills the following requirements:
make testhas completed successfullyPR Type
What kind of change does this PR introduce?
What is the current behavior?
For each depend service, each Service pings Consul every 15 seconds to get the latest URL which never changes.
Issue Number: #2594
What is the new behavior?
No longer monitor the client URLs. Just set the url went Client is created and use it.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information