Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client monitoring #2594

Closed
lenny-goodell opened this issue Jun 19, 2020 · 0 comments · Fixed by #2595
Closed

Remove client monitoring #2594

lenny-goodell opened this issue Jun 19, 2020 · 0 comments · Fixed by #2595
Assignees
Labels
2-medium priority denoting issues with cross-cutting project impact core-services enhancement New feature or request hanoi Hanoi release security-services support-services system-management tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Jun 19, 2020

🚀 Feature Request

Relevant Package

This feature request is for all edgex-go services BootstrapHandler in each services init.go

Description

Per the Core WG 6/18/2020 meeting the active Client Monitoring via polling Consul is to be removed.

client initialization like this

	mdc := metadata.NewDeviceClient(
		urlclient.New(
			ctx,
			wg,
			registryClient,
			clients.CoreMetaDataServiceKey,
			clients.ApiDeviceRoute,
			configuration.Service.ClientMonitor,
			configuration.Clients["Metadata"].Url()+clients.ApiDeviceRoute,
		),
	)

changes to:

	mdc := metadata.NewDeviceClient(local.New(configuration.Clients["Metadata"].Url()+clients.ApiDeviceRoute))

Note: local.New() needs to come from go-mod-core-contracts

Once the changes have been made the following packages can be removed:

  • pkg/urlclient
  • pkg/endpoint

ServiceInfo.ClientMonitor can also be removed from struct and all configuration toml files.

@lenny-goodell lenny-goodell added enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds labels Jun 19, 2020
@lenny-goodell lenny-goodell added 2-medium priority denoting issues with cross-cutting project impact core-services hanoi Hanoi release security-services support-services system-management labels Jun 22, 2020
@lenny-goodell lenny-goodell self-assigned this Jun 22, 2020
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jun 22, 2020
closes edgexfoundry#2594

Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jun 22, 2020
closes edgexfoundry#2594

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell linked a pull request Jun 23, 2020 that will close this issue
15 tasks
lenny-goodell added a commit that referenced this issue Jun 25, 2020
closes #2594

Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium priority denoting issues with cross-cutting project impact core-services enhancement New feature or request hanoi Hanoi release security-services support-services system-management tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant