Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpointer Clean Up #2099

Closed
michaelestrin opened this issue Nov 11, 2019 · 0 comments · Fixed by #2100
Closed

Endpointer Clean Up #2099

michaelestrin opened this issue Nov 11, 2019 · 0 comments · Fixed by #2100
Assignees
@michaelestrin
Labels
geneva
Milestone
EdgeX Geneva

Comments

@michaelestrin
Copy link
Member

Alternate Endpointer contract implementation that encapsulates go routine and stream creation and avoids exposing recently added Fetch() method.

Clean up work introduced in edgexfoundry/go-mod-core-contracts#150 (PR edgexfoundry/go-mod-core-contracts#151).

Dependent on edgexfoundry/go-mod-core-contracts#183.
@michaelestrin michaelestrin self-assigned this Nov 11, 2019
@michaelestrin michaelestrin mentioned this issue Nov 11, 2019
Merged
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 11, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
b5f0f4f 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 12, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
9f42f1d 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 12, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
65fab30 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 12, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
a0ee9f2 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 12, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
dd714c2 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 13, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
7e704c2 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 13, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
71749e9 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
michaelestrin added a commit to michaelestrin/edgex-go that referenced this issue Nov 13, 2019
@michaelestrin
Alternate Endpointer contract implementation that encapsulates
b60bcde 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: edgexfoundry#2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
tsconn23 pushed a commit that referenced this issue Nov 14, 2019
@michaelestrin @tsconn23
Alternate Endpointer contract implementation that encapsulates (#2100)
373280d 
go routine and stream creation and avoids exposing recently added
Fetch() method.

Fixes: #2099

Signed-off-by: Michael Estrin <m.estrin@dell.com>
@brandonforster brandonforster added this to the EdgeX Geneva milestone Nov 14, 2019
lenny-goodell pushed a commit that referenced this issue Dec 2, 2020
@weichou1229
feat(metadata): Implement GET /deviceprofile/model/{model} V2 API (#2914
0d0448a 
)

* feat(metadata): Implement GET /deviceprofile/model/{model} V2 API
Implement GET /deviceprofile/model/{model} V2 API according to the doc https://app.swaggerhub.com/apis-docs/EdgeXFoundry1/core-metadata/2.x#/default/get_deviceprofile_model__model_
Fix #2099

* refactor(data): Upgrade go-mod-core-contract version
Upgrade go-mod-core-contract version and modify API doc and testing for new changes.

* refactor(metadata): Use v2 instead of the contractsV2 alias name
Remove the duplicate import and use v2 instead of the contractsV2 alias name
Fix #2915

Signed-off-by: weichou <weichou1229@gmail.com>
jim-wang-intel pushed a commit to jim-wang-intel/edgex-go that referenced this issue Dec 15, 2020
@weichou1229 @jim-wang-intel
feat(metadata): Implement GET /deviceprofile/model/{model} V2 API (ed…
464f00e 
…gexfoundry#2914)

* feat(metadata): Implement GET /deviceprofile/model/{model} V2 API
Implement GET /deviceprofile/model/{model} V2 API according to the doc https://app.swaggerhub.com/apis-docs/EdgeXFoundry1/core-metadata/2.x#/default/get_deviceprofile_model__model_
Fix edgexfoundry#2099

* refactor(data): Upgrade go-mod-core-contract version
Upgrade go-mod-core-contract version and modify API doc and testing for new changes.

* refactor(metadata): Use v2 instead of the contractsV2 alias name
Remove the duplicate import and use v2 instead of the contractsV2 alias name
Fix edgexfoundry#2915

Signed-off-by: weichou <weichou1229@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelestrin michaelestrin

Labels
geneva
Projects
None yet
Milestone
EdgeX Geneva
Development

Successfully merging a pull request may close this issue.

Endpointer Clean Up michaelestrin/edgex-go
2 participants
@michaelestrin @brandonforster