Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create UCR for performance test harness #1318

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: Create UCR for performance test harness #1318

merged 1 commit into from
Feb 1, 2024

Conversation

cherrycl
Copy link
Contributor

@cherrycl cherrycl commented Dec 5, 2023

Closes #1317

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

lenny-goodell
lenny-goodell previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumpingliu
Copy link
Contributor

@lenny-intel there's an invalid link, but I've already fixed this on #1333

farshidtz
farshidtz requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is already up for a vote. I would nevertheless submit my delayed review.

docs_src/design/ucr/Performance-Test-Harness.md Outdated Show resolved Hide resolved
docs_src/design/ucr/Performance-Test-Harness.md Outdated Show resolved Hide resolved
docs_src/design/ucr/Performance-Test-Harness.md Outdated Show resolved Hide resolved
docs_src/design/ucr/Performance-Test-Harness.md Outdated Show resolved Hide resolved
docs_src/design/ucr/Performance-Test-Harness.md Outdated Show resolved Hide resolved
farshidtz
farshidtz previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

@cherrycl
feat: Create UCR for performance test harness
aba42dd 
Signed-off-by: Cherry Wang <cherry@iotechsys.com>
@cherrycl
Copy link
Contributor Author

cherrycl commented Feb 1, 2024

Update Changelog.

cloudxxx8
cloudxxx8 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 0cdc632 into edgexfoundry:main Feb 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

@farshidtz farshidtz farshidtz left review comments

@lenny-goodell lenny-goodell lenny-goodell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create UCR for performance test harness
5 participants
@cherrycl @jumpingliu @farshidtz @cloudxxx8 @lenny-goodell