This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
feat(security): Remove Vault's healthy check in Consul #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vault's backend changes from consul to filesystem and the Vault's healthy check now becomes superfluous. The automatically generated healthy check in Vault now is gone due to Vault's backend storage is not dependent on Consul any more. This together with edgex-go's change shall remove the dependency of Vault from Consul. Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
4 tasks
|
@lenny-intel or @jpwhitemn or @bnevis-i if you have the written permission please add @beaufrusetta, @bnevis-i, @lenny-intel, @hutchic as reviewers . This is for Ireland scope. I don't have that permission. Thanks. |
Yeah @lenny-intel - when do I become "git official" with EdgeX? 😆 |
bnevis-i
approved these changes
Nov 18, 2020
lenny-goodell
approved these changes
Nov 19, 2020
2 tasks
|
@lenny-intel could we also move this to PR ready? |
hutchic
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Vault's backend being changed from consul to filesystem, Vault's healthy check now becomes superfluous.
The original automatically generated healthy check in Vault now is gone due to Vault's backend storage is not dependent on Consul any more.
This together with edgex-go's change shall remove the dependency of Vault from Consul.
Signed-off-by: Jim Wang yutsung.jim.wang@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/docker-edgex-consul/blob/master/.github/Contributing.md.
What is the current behavior?
Vault's healthy check within Consul
Issue Number: edgexfoundry/edgex-go#2882
What is the new behavior?
No Vault's healthy check directly from Consul
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information
Related to edgexfoundry/edgex-go#2882
Also see PR: edgexfoundry/edgex-go#2886