Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump device-sdk-go version #330

Merged
merged 2 commits into from
Jan 30, 2023
Merged

build(deps): bump device-sdk-go version #330

merged 2 commits into from
Jan 30, 2023

Conversation

chr1shung
Copy link

@chr1shung chr1shung commented Jan 19, 2023

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  1. Run device-virtual from this branch and core-metadata from feat: remove device callback calls edgex-go#4269
  2. Verified device-virtual is correctly bootstrapped, device callback is successfully triggered by system event:
# docker logs edgex-device-virtual | grep 'System event received'
level=DEBUG ts=2023-01-19T02:14:04.758228329Z app=device-virtual source=callback.go:55 msg="System event received on message queue. Topic: edgex/system-events/core-metadata/device/#/device-virtual/#, Correlation-id: c35397dd-bf36-49b9-aea1-823ad7afea5c "
level=DEBUG ts=2023-01-19T02:14:04.760643907Z app=device-virtual source=callback.go:55 msg="System event received on message queue. Topic: edgex/system-events/core-metadata/device/#/device-virtual/#, Correlation-id: c35397dd-bf36-49b9-aea1-823ad7afea5c "
level=DEBUG ts=2023-01-19T02:14:04.764571466Z app=device-virtual source=callback.go:55 msg="System event received on message queue. Topic: edgex/system-events/core-metadata/device/#/device-virtual/#, Correlation-id: c35397dd-bf36-49b9-aea1-823ad7afea5c "
level=DEBUG ts=2023-01-19T02:14:04.766125679Z app=device-virtual source=callback.go:55 msg="System event received on message queue. Topic: edgex/system-events/core-metadata/device/#/device-virtual/#, Correlation-id: c35397dd-bf36-49b9-aea1-823ad7afea5c "
level=DEBUG ts=2023-01-19T02:14:04.767673709Z app=device-virtual source=callback.go:55 msg="System event received on message queue. Topic: edgex/system-events/core-metadata/device/#/device-virtual/#, Correlation-id: c35397dd-bf36-49b9-aea1-823ad7afea5c "

New Dependency Instructions (If applicable)

Signed-off-by: Chris Hung <chris@iotechsys.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #330 (9549dd1) into main (dc1ad58) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          13       13           
  Lines         860      860           
=======================================
  Hits          504      504           
  Misses        312      312           
  Partials       44       44           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit da9c53c into edgexfoundry:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants