Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Device Add/Update/Delete REST API with Device System Events #1259

Closed
lenny-goodell opened this issue Nov 17, 2022 · 0 comments · Fixed by #1276
Closed

Replace Device Add/Update/Delete REST API with Device System Events #1259

lenny-goodell opened this issue Nov 17, 2022 · 0 comments · Fixed by #1276
Assignees
@chr1shung
Labels
enhancement New feature or request
Milestone
Minnesota

Comments

@lenny-goodell
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

Device callbacks from Core Metadata

Description [REQUIRED]

The device callback can be replaced by subscribing the the Device System Events already in place from Core Metadata

Describe the solution you'd like

Subscribe to the Device System Events via MessageBus and route to exiting application code to handle the Add/Update/Delete Device.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@lenny-goodell lenny-goodell added the enhancement New feature or request label Nov 17, 2022
@lenny-goodell lenny-goodell added this to the Minnesota milestone Nov 17, 2022
@lenny-goodell lenny-goodell mentioned this issue Nov 17, 2022
Closed
chr1shung pushed a commit to chr1shung/device-sdk-go that referenced this issue Jan 10, 2023
feat!: replace REST device callbacks with System Events
cc748b5 
BREAKING CHANGE:
the following device callback REST endpoints is removed:
- POST /callback/device
- PUT /callback/device
- DELETE /callback/device/name/{name}

closes edgexfoundry#1259

Signed-off-by: Chris Hung <chris@iotechsys.com>
chr1shung pushed a commit to chr1shung/device-sdk-go that referenced this issue Jan 10, 2023
feat!: replace REST device callbacks with System Events
6a7a60c 
BREAKING CHANGE:
the following device callback REST endpoints are removed:
- POST /callback/device
- PUT /callback/device
- DELETE /callback/device/name/{name}

closes edgexfoundry#1259

Signed-off-by: Chris Hung <chris@iotechsys.com>
This was referenced Jan 10, 2023
Merged
Merged
chr1shung pushed a commit to chr1shung/device-sdk-go that referenced this issue Jan 11, 2023
feat!: replace REST device callbacks with System Events
96b3ac1 
BREAKING CHANGE:
the following device callback REST endpoints are removed:
- POST /callback/device
- PUT /callback/device
- DELETE /callback/device/name/{name}

closes edgexfoundry#1259

Signed-off-by: Chris Hung <chris@iotechsys.com>
chr1shung pushed a commit to chr1shung/device-sdk-go that referenced this issue Jan 12, 2023
feat!: replace REST device callbacks with System Events
d79dc86 
BREAKING CHANGE:
the following device callback REST endpoints are removed:
- POST /callback/device
- PUT /callback/device
- DELETE /callback/device/name/{name}

closes edgexfoundry#1259

Signed-off-by: Chris Hung <chris@iotechsys.com>
chr1shung pushed a commit to chr1shung/device-sdk-go that referenced this issue Jan 18, 2023
feat!: replace REST device callbacks with System Events
3f884ed 
BREAKING CHANGE:
the following device callback REST endpoints are removed:
- POST /callback/device
- PUT /callback/device
- DELETE /callback/device/name/{name}

closes edgexfoundry#1259

Signed-off-by: Chris Hung <chris@iotechsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chr1shung chr1shung

Labels
enhancement New feature or request
Projects
None yet
Milestone
Minnesota
Development

Successfully merging a pull request may close this issue.

feat!: replace REST device callbacks with System Events chr1shung/device-sdk-go
2 participants
@chr1shung @lenny-goodell