Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(snap): add snap CI workflow #73

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Apr 19, 2022

The workflow added here will activate only after it has been merged into the main. In the meantime, MonicaisHer#1 that is against the fork can be taken as a reference.

Signed-off-by: Mengyi Wang mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) add CI workflow local MonicaisHer/device-rfid-llrp-go#1
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@MonicaisHer MonicaisHer changed the title test: add snap CI workflow test(snap): add snap CI workflow Apr 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #73 (19c372e) into main (e0db465) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   41.11%   41.08%   -0.04%     
==========================================
  Files          21       21              
  Lines        9016     9016              
==========================================
- Hits         3707     3704       -3     
- Misses       4141     4142       +1     
- Partials     1168     1170       +2     
Impacted Files Coverage Δ
internal/llrp/reader.go 40.13% <0.00%> (-0.67%) ⬇️
internal/retry/retry.go 93.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0db465...19c372e. Read the comment docs.

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@tonyespy tonyespy merged commit 8b44d22 into edgexfoundry:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants