-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added "make lint" to target and added it to make test. Resolved… #60
Conversation
b147648
to
d6f935d
Compare
internal/llrp/reader_test.go
Outdated
//nolint: gosec | ||
sz := rand.Int31n(1024) | ||
data := make([]byte, sz) | ||
//nolint: gosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does linter no like in these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal/llrp/reader_test.go:395:10: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
sz := rand.Int31n(1024)
c8e903b
to
9b29164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9b29164
to
db17ab3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but want @bnevis-i to also review.
… all lint errors as well Signed-off-by: Marc-philippe Fuller <marc-philippe.fuller@intel.com>
db17ab3
to
6168474
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat: Added "make lint" to target and added it to make test. Resolved all lint errors as well
Signed-off-by: Marc-philippe Fuller marc-philippe.fuller@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)
N/A