feat: Added "make lint" to target and added it to make test. Resolved… #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpfuller
force-pushed
the
lint-feature
branch
from
b147648
to
d6f935d
Compare
lenny-goodell
requested changes
Jan 24, 2022
internal/llrp/reader_test.go
Outdated
Comment on lines
395
to
398
| //nolint: gosec | ||
| sz := rand.Int31n(1024) | ||
| data := make([]byte, sz) | ||
| //nolint: gosec |
There was a problem hiding this comment.
What does linter no like in these?
There was a problem hiding this comment.
internal/llrp/reader_test.go:395:10: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
sz := rand.Int31n(1024)
c8e903b
to
9b29164
Compare
lenny-goodell
requested changes
Jan 26, 2022
marcpfuller
force-pushed
the
lint-feature
branch
from
9b29164
to
db17ab3
Compare
lenny-goodell
previously approved these changes
Jan 26, 2022
… all lint errors as well Signed-off-by: Marc-philippe Fuller <marc-philippe.fuller@intel.com>
marcpfuller
force-pushed
the
lint-feature
branch
from
db17ab3
to
6168474
Compare
lenny-goodell
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added "make lint" to target and added it to make test. Resolved all lint errors as well
Signed-off-by: Marc-philippe Fuller marc-philippe.fuller@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)
N/A