Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename command line flags for the sake of consistency #492

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

lenny-goodell
Copy link
Member

BREAKING CHANGE: renamed -c/--confdir to -cd/--configDirand -f/--file to -cf/--configFile

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    docs: Update docs for changes of renaming config options in 3.0 edgex-docs#916

Testing Instructions

Build service
run ./app-service-configurable -h
verify flags in help have new names
run ./app-service-configurable --confdir something
verify error due to --confdir unknown
run ./app-service-configurable --configDir something
verify error due to file something not found

New Dependency Instructions (If applicable)

BREAKING CHANGE: renamed -c/--confdir to -cd/--configDirand -f/--file to -cf/--configFile

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lenny-goodell lenny-goodell merged commit cb787cf into edgexfoundry:main Jan 3, 2023
@lenny-goodell lenny-goodell deleted the options branch January 3, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants