Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add external-mqtt-trigger configuration file for TAF test #338

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

cherrycl
Copy link
Contributor

Add external-mqtt-trigger for edgexfoundry/edgex-taf issue #514.

Signed-off-by: Cherry Wang cherry@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  1. Deploy app-service with external-mqtt-trigger profile and mqtt-broker.
  2. Subscribe both topics "external-request": SubscribeTopics in Trigger and "edgex-export": Topic in Pipeline Function.
  3. Publish a message "test message" to the topic "external-request" which is defined in the profile.
  4. Both topics, external-request and edgex-export, receive the message

New Dependency Instructions (If applicable)

Signed-off-by: Cherry Wang <cherry@iotechsys.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 2fab480 into edgexfoundry:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants