feat: Update profiles for new subsribe topic for V2 DTOs #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is in draft until PR edgexfoundry/app-functions-sdk-go#616 is merged. |
lenny-goodell
commented
Jan 25, 2021
| @@ -115,8 +115,8 @@ Timeout = "30s" | |||
| Port = 48080 | |||
|
|
|||
| [Binding] | |||
| Type="messagebus" | |||
| SubscribeTopics="events" | |||
| Type="edgex-messagebus" | |||
There was a problem hiding this comment.
Note old type of messagebus is going away in Ireland. Type of edgex-messagebus was added for Hanoi.
AlexCuse
previously approved these changes
Jan 25, 2021
jim-wang-intel
previously approved these changes
Jan 25, 2021
All profiles using ZMQ for MessageBus have `edgex/events` added to existing `SubscribeTopics`. All profiles using MQTT for MessageBus have `edgex/events/#` added to existing `SubscribeTopics`. closes edgexfoundry#174 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
dismissed stale reviews from jim-wang-intel and AlexCuse
via
cc45230
jim-wang-intel
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using SDK that only supports V1 Event Model
All profiles that use MessageBus subscribe to
eventstopic only.Issue Number: #174
What is the new behavior?
Updated to latest SDK that supports V2 Event DTO
All profiles using ZMQ for MessageBus have
edgex/eventsadded to existingSubscribeTopics.All profiles using MQTT for MessageBus have
edgex/events/#added to existingSubscribeTopics.Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information