feat: Expect V2 Event DTO from triggers. #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
rsdmike,
jpwhitemn,
adam-intel and
brian-intel
lenny-goodell
force-pushed
the
v2-event-dto
branch
from
ddfe917
to
4e36144
Compare
|
Putting this on hold as the DTO that will be received from the MessageBus is changing from |
lenny-goodell
force-pushed
the
v2-event-dto
branch
2 times, most recently
from
b8d681f
to
a57b559
Compare
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 60.98% 62.24% +1.26%
==========================================
Files 31 31
Lines 1830 1907 +77
==========================================
+ Hits 1116 1187 +71
+ Misses 640 639 -1
- Partials 74 81 +7
Continue to review full report at Codecov.
|
lenny-goodell
force-pushed
the
v2-event-dto
branch
3 times, most recently
from
8c202e8
to
6a64ff4
Compare
lenny-goodell
removed
the
hold
lenny-goodell
force-pushed
the
v2-event-dto
branch
2 times, most recently
from
6f4c8a6
to
ce7c848
Compare
Triggers expect a V2 AddEventRequest DTO Appropriate pipeline functions now expect a V2 Event DTO. V1 Event model temporarily supported by converting V1 Event to a V2 Event DTO. closes #595 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
v2-event-dto
branch
from
ce7c848
to
578b4c2
Compare
jim-wang-intel
requested changes
Jan 22, 2021
Merged
12 tasks
AlexCuse
previously approved these changes
Jan 24, 2021
Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Triggers and some pipeline function expect a V1 Event model
Issue Number: #595
What is the new behavior?
Triggers and appropriate pipeline functions now expect a V2 Event DTO.
V1 Event model temporarily supported by converting V1 Event to a V2 Event DTO.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information