Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix MQTT Trigger to set ReceivedTopic #910

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

ReceivedTopic not being set by MQTT Trigger

Issue Number: #909

What is the new behavior?

ReceivedTopic now being set by MQTT Trigger

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

closes edgexfoundry#909

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell linked an issue Jun 23, 2021 that may be closed by this pull request
Copy link
Contributor

@AlexCuse AlexCuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #910 (9882c7d) into master (ead6592) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files          33       33           
  Lines        2107     2107           
=======================================
  Hits         1341     1341           
  Misses        675      675           
  Partials       91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead6592...9882c7d. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 5491d08 into edgexfoundry:master Jun 23, 2021
@lenny-goodell lenny-goodell deleted the set-received-topic branch June 23, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT Trigger doesn't set the ReceivedTopic
3 participants