-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to chain HTTP exports for multiple destinations #860
feat: Add ability to chain HTTP exports for multiple destinations #860
Conversation
820c102
to
a149896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HTTP export now has option to return the input data and optionally continue pipeline on send errors. This enables the ability to chain multiple HTTP exports in the pipeline to send the same data to multiple destinations. Configurable pipeline now supports multiple instances of same function to be configured. Configuration names that start with the actual function name now match. i.e. `HttpExport` matches `HttpExport` and `HttpExport2` also matches `HttpExport`. closes #256 Signed-off-by: lenny <leonard.goodell@intel.com>
a149896
to
8ac2140
Compare
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 62.35% 63.14% +0.78%
==========================================
Files 31 31
Lines 2048 2089 +41
==========================================
+ Hits 1277 1319 +42
+ Misses 679 678 -1
Partials 92 92
Continue to review full report at Codecov.
|
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
HTTP export returns HTTP response and stops pipeline on send errors. This block the ability to chain multiple HTTP exports in the pipeline to send the same data to multiple destinations.
Configurable pipeline only allows once instance of each function to be configured. Configuration names must match actual function names exactly. i.e.
HttpExport
matchesHttpExport
, butHttpExport2
does not matchHttpExport
Issue Number: #256
What is the new behavior?
HTTP export now has option to return the input data and optionally continue pipeline on send errors. This enables the ability to chain multiple HTTP exports in the pipeline to send the same data to multiple destinations.
Configurable pipeline now supports multiple instance functions to be configured. Configuration names that start with the actual function name now match. i.e.
HttpExport
matchesHttpExport
andHttpExport2
also matchesHttpExport
.Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information