feat: Add custom structured configuration capability #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 22, 2021
lenny-goodell
changed the title
lenny-goodell
force-pushed
the
custom-config2
branch
from
dc6987f
to
772a84f
Compare
AlexCuse
previously approved these changes
Mar 22, 2021
lenny-goodell
dismissed stale reviews from jim-wang-intel and AlexCuse
via
cad640d
…hanges Thease are need for the service's witaing got chnages wait loop so it exits properly Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
custom-config2
branch
from
cad640d
to
8da60f0
Compare
jim-wang-intel
previously approved these changes
Mar 22, 2021
Signed-off-by: lenny <leonard.goodell@intel.com>
jim-wang-intel
previously approved these changes
Mar 23, 2021
Use of channel causes too much unneeded complexity when a callback function will suffice. Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
dismissed stale reviews from jim-wang-intel and AlexCuse
via
6b7834d
lenny-goodell
force-pushed
the
custom-config2
branch
from
5c8d84a
to
6b7834d
Compare
jim-wang-intel
previously approved these changes
Mar 23, 2021
This was referenced Mar 23, 2021
Closed
Signed-off-by: lenny <leonard.goodell@intel.com>
jim-wang-intel
approved these changes
Mar 23, 2021
AlexCuse
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No custom structured configuration capability exists
No capability to watch custom configuration for changes exists
Issue Number: #557 & #578
What is the new behavior?
Custom structured configuration capability now exists
Capability to watch a section of the custom configuration for changes when using the Configuration Provider now exists
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information