feat(sdk): Multi-topic messagebus subscriptions #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCuse
force-pushed
the
messagebus-multiple-subscribe
branch
from
39fd6b1
to
53ceb16
Compare
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 61.76% 61.81% +0.04%
==========================================
Files 31 31
Lines 1810 1820 +10
==========================================
+ Hits 1118 1125 +7
- Misses 619 621 +2
- Partials 73 74 +1
Continue to review full report at Codecov.
|
AlexCuse
changed the title
AlexCuse
force-pushed
the
messagebus-multiple-subscribe
branch
2 times, most recently
from
32be6e9
to
165dc69
Compare
AlexCuse
force-pushed
the
messagebus-multiple-subscribe
branch
2 times, most recently
from
545fe44
to
92b338f
Compare
Change BindingInfo.SubscribeTopic to .SubscribeTopics, treat as comma separated string. Support multi-topic subscriptions in MQTT trigger simply by looping on connect/reconnect, for messagebus trigger introduce a "collector" channel. Signed-off-by: Alex Ullrich <alex.ullrich@gmail.com>
AlexCuse
force-pushed
the
messagebus-multiple-subscribe
branch
from
92b338f
to
d780d8e
Compare
|
LGTM @lenny-intel. The only thing I see that might be missing is testing the multi-topic aspect of the subscribe (apologies if I missed this just doing a quick scan on github here). Would be pretty easy to crib the test from my PR, or add it to another test case. |
|
Closing due to #625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an intermediate 'collector' channel to messagebus trigger to
aggregate messages from multiple topics for processing.
Signed-off-by: Alex Ullrich alex.ullrich@gmail.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
#596
What is the new behavior?
Allow multi-topic messagebus subscription.
Does this PR introduce a breaking change?
BindingInfo.SubscribeTopic was renamed to BindingInfo.SubscribeTopics - config files will need to be updated accordingly
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information