Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update scopes and types for conventional commits #561

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Oct 23, 2020

closes #495

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #495

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

N/A

Are there any specific instructions or things that should be known prior to reviewing?

Other information

closes #495

Signed-off-by: Mike <michael.johanson@intel.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 07f5e21 into edgexfoundry:master Oct 23, 2020
@rsdmike rsdmike deleted the #495 branch October 23, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update conventional commit Types and Scopes
2 participants