Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consume watch for common Writable config changes #1347

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run EdgeX non-secure stack
Build app template from this branch and run from command line with -cp
Verify logs contain the following:

"listening for private config changes"
"listening for all services common config changes"
"listening for application service common config changes" 

In Consul add Writable/Telemetry/Interval to edgex/v3/core-common-config-bootstrapper/app-services with value of 20s
Verify the log contains:

"Writeable configuration has been updated from the Configuration Provider"
"Telemetry interval has been updated. Processing new value..."
"Metrics Manager report interval changed to 20s"

New Dependency Instructions (If applicable)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell added the enhancement New feature or request label Mar 10, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Mar 10, 2023
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-wang-intel jim-wang-intel merged commit 87b6fb4 into edgexfoundry:main Mar 10, 2023
@lenny-goodell lenny-goodell deleted the writable branch March 10, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants