feat: Add ability to chain HTTP exports for multiple destinations #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
http-export-chaining
branch
4 times, most recently
from
820c102
to
a149896
Compare
AlexCuse
previously approved these changes
May 28, 2021
HTTP export now has option to return the input data and optionally continue pipeline on send errors. This enables the ability to chain multiple HTTP exports in the pipeline to send the same data to multiple destinations. Configurable pipeline now supports multiple instances of same function to be configured. Configuration names that start with the actual function name now match. i.e. `HttpExport` matches `HttpExport` and `HttpExport2` also matches `HttpExport`. closes #256 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
http-export-chaining
branch
from
a149896
to
8ac2140
Compare
rsdmike
approved these changes
Jun 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 62.35% 63.14% +0.78%
==========================================
Files 31 31
Lines 2048 2089 +41
==========================================
+ Hits 1277 1319 +42
+ Misses 679 678 -1
Partials 92 92
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
HTTP export returns HTTP response and stops pipeline on send errors. This block the ability to chain multiple HTTP exports in the pipeline to send the same data to multiple destinations.
Configurable pipeline only allows once instance of each function to be configured. Configuration names must match actual function names exactly. i.e.
HttpExportmatchesHttpExport, butHttpExport2does not matchHttpExportIssue Number: #256
What is the new behavior?
HTTP export now has option to return the input data and optionally continue pipeline on send errors. This enables the ability to chain multiple HTTP exports in the pipeline to send the same data to multiple destinations.
Configurable pipeline now supports multiple instance functions to be configured. Configuration names that start with the actual function name now match. i.e.
HttpExportmatchesHttpExportandHttpExport2also matchesHttpExport.Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information