refactor: Restructure Trigger configuration #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 26, 2021
lenny-goodell
force-pushed
the
trigger-config
branch
from
903d8fc
to
6beef4c
Compare
close #719 BREAKING CHANGE: - Renamed `Binding` to `Trigger` - Removed deprecated `MessageBus` trigger type, replaced by`edgex-messagebus` - Renamed `MessageBus` to `EdgexMessageBus` - Move `EdgexMessageBus` and `ExternalMqtt` under `Trigger` configuration Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
trigger-config
branch
from
6beef4c
to
1eae58f
Compare
jim-wang-intel
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Trigger configuration is under
[Binding]and the sub configurationsMessageBusandExternalMqttare disjoint.Issue Number: #719
What is the new behavior?
Removed deprecated
MessageBustrigger type, which was replaced byedgex-messagebusTrigger configuration is now under
[Trigger]and the sub configurationsEdgexMessageBusandExternalMqttunder sub-sections for[Trigger]Does this PR introduce a breaking change?
BREAKING CHANGE:
BindingtoTriggerMessageBustrigger type, replaced byedgex-messagebusMessageBustoEdgexMessageBusEdgexMessageBusandExternalMqttunderTriggerconfigurationAre there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information