Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Refactor Binding configuration #719

Closed
lenny-goodell opened this issue Feb 25, 2021 · 0 comments · Fixed by #724
Closed

SDK: Refactor Binding configuration #719

lenny-goodell opened this issue Feb 25, 2021 · 0 comments · Fixed by #724
Assignees
Labels
3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Milestone

Comments

@lenny-goodell
Copy link
Member

Rename Binding to Trigger and move the configuration for the types under Trigger . TOML will look like this:

[Trigger]
Type="http"

or

[Trigger]
Type="edgex-messagebus"
SubscribeTopics="events, edgex/events"
PublishTopic="example"
  [Trigger.MessageBus]
  Type = "zero"
      [Trigger.MessageBus.SubscribeHost]
      Host = "localhost"
      Port = 5563
      Protocol = "tcp"
      [Trigger.MessageBus.PublishHost]
      Host = "*"
      Port = 5565
      Protocol = "tcp"

or

[Trigger]
Type="external-mqtt"
SubscribeTopics="something"
PublishTopic="example"
  [Trigger.ExternalMqtt]
  Url = "tcp://localhost:1883"
  ClientId = "ThisAppService"
  ConnectTimeout = "5s"
  AutoReconnect = true
  KeepAlive = 5
  QoS = 0
  Retain = false
  SkipCertVerify = false
  SecretPath = ""
  AuthMode = "none"
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds labels Feb 25, 2021
@lenny-goodell lenny-goodell added this to the Ireland milestone Feb 25, 2021
@lenny-goodell lenny-goodell self-assigned this Feb 25, 2021
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Feb 26, 2021
close #719

BREAKING CHANGE:
- Renamed `Binding` to `Trigger`
- Renamed `MessageBus` to `EdgexMessageBus`
- Move `EdgexMessageBus` and `ExternalMqtt` under `Trigger` configuration

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell linked a pull request Feb 26, 2021 that will close this issue
12 tasks
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Feb 26, 2021
close #719

BREAKING CHANGE:
- Renamed `Binding` to `Trigger`
- Removed deprecated `MessageBus` trigger type, replaced by`edgex-messagebus`
- Renamed `MessageBus` to `EdgexMessageBus`
- Move `EdgexMessageBus` and `ExternalMqtt` under `Trigger` configuration

Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Feb 26, 2021
close #719

BREAKING CHANGE:
- Renamed `Binding` to `Trigger`
- Removed deprecated `MessageBus` trigger type, replaced by`edgex-messagebus`
- Renamed `MessageBus` to `EdgexMessageBus`
- Move `EdgexMessageBus` and `ExternalMqtt` under `Trigger` configuration

Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell added a commit that referenced this issue Feb 26, 2021
closes #719 & #655

BREAKING CHANGE:
- Renamed `Binding` to `Trigger`
- Removed deprecated `MessageBus` trigger type, replaced by`edgex-messagebus`
- Renamed `MessageBus` to `EdgexMessageBus`
- Move `EdgexMessageBus` and `ExternalMqtt` under `Trigger` configuration

Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant