Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for multiple MessageBus subscriptions #625

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Only one topic allowed for MessageBus trigger

Issue Number: #596

What is the new behavior?

Multiple topics allowed for the MessageBus trigger

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #625 (ca4780b) into master (baae3ee) will increase coverage by 0.01%.
The diff coverage is 70.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   60.81%   60.83%   +0.01%     
==========================================
  Files          31       31              
  Lines        1807     1823      +16     
==========================================
+ Hits         1099     1109      +10     
- Misses        635      640       +5     
- Partials       73       74       +1     
Impacted Files Coverage Δ
appsdk/sdk.go 33.33% <0.00%> (ø)
internal/trigger/messagebus/messaging.go 70.58% <73.21%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baae3ee...ca4780b. Read the comment docs.

@lenny-goodell lenny-goodell force-pushed the multi-subscribe branch 2 times, most recently from fdff1cd to 63447ee Compare January 8, 2021 17:47
close #596

Signed-off-by: lenny <leonard.goodell@intel.com>
Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell merged commit b307360 into edgexfoundry:master Jan 11, 2021
@lenny-goodell lenny-goodell deleted the multi-subscribe branch January 11, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants