Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive messages on a non-UI thread #459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HawkiesZA
Copy link

When setting a new callback, messages are received on the UI thread. This completely locks up the UI if there are lots of messages being received. This has been discussed before here: #207, but it seems that the solution was never implemented.

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • You have signed the Eclipse ECA
  • All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
  • If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
  • If this is new functionality, You have added the appropriate Unit tests.

@tabilzad
Copy link

LocalBroadcastManager is a lot more efficient than global broadcasting through context. With the latter if the massage payload is too big - it will throw a TransactionTooLargeException.

@HawkiesZA
Copy link
Author

While that may be true, LocalBroadcastManager doesn't appear to have a way to address the problem of locking up the UI thread as explained above. I think this may just be a quick fix under the current situation, but actually we should be looking at a different pattern rather than BroadcastManagers, considering that LocalBroadcastManager has been deprecated as well.

@ishdemon
Copy link

Use HiveMqtt instead of paho..its better maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants