Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Update vsce to 1.95.1 #327

Closed
wants to merge 1 commit into from
Closed

Conversation

keynslug
Copy link

@keynslug keynslug commented Sep 8, 2021

The version of vsce currently being in use at the time of submitting this PR (1.93.0) is affected by microsoft/vscode-vsce#588 which reportedly breaks a lot of extensions with non-trivial vscode-ignore rules.

For example, one of the affected extensions that I rely on heavily is https://github.com/erlang-ls/vscode. The 0.0.28 release hasn't been published on open-vsx.org for quite some time already due to being hit by the aforementioned issue. Misinterpreting some ignore rules results in the following error (as seen here):

Error: The specified icon 'extension/erlang_ls/images/erlang-ls-logo-small.png' wasn't found in the extension.
    at IconProcessor.onEnd (/home/runner/work/publish-extensions/publish-extensions/node_modules/vsce/out/package.js:576:35)
    at /home/runner/work/publish-extensions/publish-extensions/node_modules/vsce/out/package.js:897:58
    at Object.<anonymous> (/home/runner/work/publish-extensions/publish-extensions/node_modules/vsce/out/util.js:111:19)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/publish-extensions/publish-extensions/node_modules/vsce/out/util.js:5:58)

Upgrading to vsce ~1.95.0 should fix that (manually confirmed by running npm install vsce@~1.95.0 && ./node_modules/.bin/vsce package successfully). Also this will likely positively affect packaging of a number of other extensions.

Signed-off-by: Andrew Mayorov <encube.ul@gmail.com>
@akosyakov
Copy link
Member

akosyakov commented Sep 9, 2021

I would prefer #326 instead. It updates to never version and fixes other issues as well.

@keynslug
Copy link
Author

keynslug commented Sep 9, 2021

I would prefer #326 instead. It updates to never version and fixes other issues as well.

Ah, nice! Wasn't aware of it. Feel free to close this PR as you see fit.

@akosyakov
Copy link
Member

new version was published 0.2.1

@keynslug keynslug closed this Sep 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants