Implement itemDefaults for completionList

[JessicaJHee]

Fixes #1561

• moves editRange and insertTextFormat to itemDefaults when supported

[datho7561]

Given the schema:

<grammar xmlns="http://relaxng.org/ns/structure/1.0"
  datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">
  <start>
    <ref name="articleContent" />
  </start>
  <define name="articleContent">
    <element name="article">
      <choice>
        <ref name="titleContent" />
        <ref name="titleLineContent" />
      </choice>
      <element name="salami">
        <text/>
      </element>
    </element>
  </define>
  <define name="titleContent">
    <choice>
      <element name="title">
        <empty />
      </element>
    </choice>
  </define>
  <define name="titleLineContent">
    <element name="title2">
      <choice>
        <ref name="lineElt"></ref>
        <ref name="thirdNest"></ref>
      </choice>
    </element>
  </define>
  <define name="thirdNest">
    <choice>
      <element name="nest1">
        <empty/>
      </element>
      <element name="nest2">
        <empty/>
      </element>
      <element name="nest3">
        <empty/>
      </element>
    </choice>
  </define>
  <define name="lineElt">
    <element name="line">
      <text />
    </element>
  </define>
</grammar>

And the document:

<?xml-model href="schema.rng"?>
<article>
    |
</article>

If I open completion at the |, I get title and title2 suggested as expected, but when I apply completion, I get the following result:

<?xml-model href="schema.rng"?>
<article>
    title
</article>

[datho7561]

It seems the itemDefaults is almost always {}, since the snippets and the element completions have different data.

[JessicaJHee]

@datho7561 Hmm it works on my end, do you have any settings set that might affect completion?

[datho7561]

I'll give it another try

[datho7561]

I know what it is, it's the binary. You will need to add org.eclipse.lsp4j.CompletionItemDefaults to the reflection configuration in order for it to work

[angelozerr]

@JessicaJHee do you see some improvement with lemminx maven with the dependency completion eclipse/lemminx-maven#482 ?

[JessicaJHee]

do you see some improvement with lemminx maven with the dependency completion eclipse/lemminx-maven#482 ?

@angelozerr I do feel that it is faster, at least on the first completion. But it is hard to put into numbers since the improvements are purely on the client side.

[angelozerr]

Yes sure I understand, I wanted just to have your feeling. Thanks for your feedback.

[datho7561]

Looks good. Thanks, Jessica!

[angelozerr]

It works great on vscode.

I cannot test with Eclipse IDE because it misses the capability eclipse/lsp4e#741 -(

[angelozerr]

Once github actions will be finished,I'm OK to merge it.

[angelozerr]

Thanks @JessicaJHee !