Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XInclude cannot be activated with binary mode #1558

Merged
merged 1 commit into from
Jul 24, 2023
Merged

XInclude cannot be activated with binary mode #1558

merged 1 commit into from
Jul 24, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr mentioned this pull request Jul 22, 2023
Closed
@datho7561 datho7561 self-requested a review July 24, 2023 12:41
datho7561
datho7561 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the use case described in the pretext issue. Thanks, Angelo!

@datho7561 datho7561 merged commit 75091d1 into eclipse:main Jul 24, 2023
4 checks passed
@JessicaJHee JessicaJHee added this to the 0.27.0 milestone Aug 2, 2023
@JessicaJHee JessicaJHee added the bug Something isn't working label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

XInclude cannot be activated with binary mode
3 participants
@angelozerr @datho7561 @JessicaJHee