-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block wise transfer tests #682
Block wise transfer tests #682
Conversation
@LukasWoodtli You will need to sign the Eclipse contributor agreement and rebase on the most recent master commit to fix the builds. |
e86865f
to
5329f0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding commit messages:
- I think there is some mix-up as the last commit clearly adds new code, not refactoring existing one as its description says.
- I think this finally resolves block transfer unit tests broken #511, yay! Would mention this in the body of the first commit (which is not just refactoring)
} | ||
static void test_block1_same_message_after_success(void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline
} | |
static void test_block1_same_message_after_success(void) { | |
} | |
static void test_block1_same_message_after_success(void) { |
406dcb3
to
fcd721e
Compare
The input buffer for the block handling functions is never modified. Therefore it can be provided as an constant pointer to the corresponding functions.
The tests are more modular and more readable now. This fixes eclipse-wakaama#511.
This thest is a simple usecase with multiple block2 transfers to send a big message.
fcd721e
to
66f1145
Compare
The test sends the same meassage twice. The message is split into blocks.
66f1145
to
52b24f1
Compare
|
||
static void test_block2_receive_simple_GET(void) { | ||
lwm2m_block_data_t *blk = NULL; | ||
/* This should be incremented for each block. But it leads to a COAP_408_REQ_ENTITY_INCOMPLETE. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug then in the existing implementation?
Some unit tests were refactored and improved.
Added also some new tests.