-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to tagged up-rust #13
Update to tagged up-rust #13
Conversation
3f4638c
to
12f8a41
Compare
12f8a41
to
4100ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I suggest to use UUri::try_from_parts
to create UUris. You might also want to consider using the L2 API for the examples.
Hey @sophokles73 -- I updated the PR with your suggestions, including adding usage of the uP-L2 APIs. Could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Remove transport handle, collapse down to lib and transport * Rearrange transport engine * Implement LocalUriProvider * Make use of new up_rust::UUri::try_from_parts * Show usage of uP-L2 APIs in hello_client and hello_service examples * Fix logic of Response handling to mean no commstatus is OK Implements [#6], [#8]
7f245c3
to
7b557b7
Compare
Updates to support the up-rust release on crates.io
This should go in after #3 and #4
Handles #6 and #8
LocalUriProvider
, will do that.