Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tagged up-rust #13

Merged

Conversation

PLeVasseur
Copy link
Contributor

@PLeVasseur PLeVasseur commented Jul 18, 2024

Updates to support the up-rust release on crates.io

This should go in after #3 and #4

Handles #6 and #8

  • Realized I missed updating to use LocalUriProvider, will do that.

@PLeVasseur PLeVasseur added the enhancement New feature or request label Jul 18, 2024
@PLeVasseur PLeVasseur changed the title Feature/update to 0.1.1 Update to up-rust 0.1.1 Jul 18, 2024
PLeVasseur added a commit to PLeVasseur/up-client-vsomeip-rust that referenced this pull request Aug 1, 2024
* Remove transport handle, collapse down to lib and transport
* Rearrange transport engine
* Implement LocalUriProvider

Implements [#6], [#8]
@PLeVasseur PLeVasseur changed the title Update to up-rust 0.1.1 Update to tagged up-rust Aug 1, 2024
PLeVasseur added a commit to PLeVasseur/up-client-vsomeip-rust that referenced this pull request Aug 1, 2024
* Remove transport handle, collapse down to lib and transport
* Rearrange transport engine
* Implement LocalUriProvider

Implements [#6], [#8]
Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I suggest to use UUri::try_from_parts to create UUris. You might also want to consider using the L2 API for the examples.

up-transport-vsomeip/examples/hello_client.rs Outdated Show resolved Hide resolved
up-transport-vsomeip/examples/hello_service.rs Outdated Show resolved Hide resolved
up-transport-vsomeip/src/lib.rs Show resolved Hide resolved
@PLeVasseur
Copy link
Contributor Author

Hey @sophokles73 -- I updated the PR with your suggestions, including adding usage of the uP-L2 APIs.

Could you take another look?

Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Remove transport handle, collapse down to lib and transport
* Rearrange transport engine
* Implement LocalUriProvider
* Make use of new up_rust::UUri::try_from_parts
* Show usage of uP-L2 APIs in hello_client and hello_service examples
  * Fix logic of Response handling to mean no commstatus is OK

Implements [#6], [#8]
@PLeVasseur PLeVasseur merged commit c9d53f3 into eclipse-uprotocol:main Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants