Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): endpoint for vulnerabilitySummary page. #2528

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat(rest): endpoint for vulnerabilitySummary page. #2528

merged 1 commit into from
Sep 6, 2024

Conversation

rudra-superrr
Copy link
Contributor

@rudra-superrr rudra-superrr commented Jul 29, 2024 •
edited
Loading

Issue: #2529

Description: new endpoint for vulnerability summary page for a project.

How To Test: run the endpoint , {PROJECTS_URL}/{id}/vulnerabilitySummary to get the result.

@rudra-superrr rudra-superrr linked an issue Jul 29, 2024 that may be closed by this pull request
Endpoint to get vulnerability summary page. #2529
Closed
@rudra-superrr rudra-superrr added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for New-UI Level for the API and UI level changes for the new-ui labels Jul 29, 2024
@rudra-superrr rudra-superrr changed the title feat(project): endpoint for vulnerabilitySummary page. feat(rest): endpoint for vulnerabilitySummary page. Jul 29, 2024
@keerthi-bl
Copy link
Contributor

Testing this

@keerthi-bl
Copy link
Contributor

Test Completed and working as expected.

image

@keerthi-bl keerthi-bl removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Aug 13, 2024
@GMishx
Copy link
Contributor

GMishx commented Aug 16, 2024

@rudra-superrr please rebase with latest main.

@rudra-superrr rudra-superrr force-pushed the feat/vulnerabilitySummary branch 3 times, most recently from b8a2d9a to fdf3fd3 Compare August 19, 2024 06:33
KoukiHama
KoukiHama requested changes Aug 31, 2024
View reviewed changes
Copy link
Member

@KoukiHama KoukiHama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put "," at the end on thrift files

libraries/datahandler/src/main/thrift/vulnerabilities.thrift Outdated Show resolved Hide resolved
libraries/datahandler/src/main/thrift/vulnerabilities.thrift Outdated Show resolved Hide resolved
@rudra-superrr
feat(project): endpoint for vulnerabilitySummary page.
993a5d9 
Signed-off-by: Rudra Chopra <prabhuchopra@gmail.com>
@rudra-superrr
Copy link
Contributor Author

Please put "," at the end on thrift files

Added comma at the end for both variables.

GMishx
GMishx approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx
Copy link
Contributor

GMishx commented Sep 6, 2024

Please put "," at the end on thrift files

@KoukiHama can you please approve the changes?

@KoukiHama
Copy link
Member

LGTM

@KoukiHama KoukiHama added ready ready to merge and removed needs code review labels Sep 6, 2024
@KoukiHama KoukiHama merged commit 5d6f974 into eclipse-sw360:main Sep 6, 2024
2 checks passed
@GMishx GMishx deleted the feat/vulnerabilitySummary branch September 6, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@KoukiHama KoukiHama KoukiHama approved these changes

Assignees
No one assigned
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint to get vulnerability summary page.
4 participants
@rudra-superrr @keerthi-bl @GMishx @KoukiHama