-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): update response API Get a single release #2009
feat(rest): update response API Get a single release #2009
Conversation
@@ -1007,4 +1092,18 @@ public void addEmbeddedComponentOwnerToComponent(HalResource halResource, Compon | |||
} | |||
} | |||
} | |||
|
|||
public void addEmbeddedSubcribeToHalResourceComponent(HalResource halResource, Component sw360Component) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method has nothing to do with this PR, right? you just added for future use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because PR(#1983) was merged before, to avoid duplicate PR I added it to this same PR.
@@ -1000,11 +995,6 @@ public static abstract class VulnerabilityApiDTOMixin extends VulnerabilityApiDT | |||
|
|||
@JsonInclude(JsonInclude.Include.NON_EMPTY) | |||
@JsonIgnoreProperties({ | |||
"assessorContactPerson", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you removed these 5 fields, as I'm not able to see any of these fields in response structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment. I updated response structure.
d73d7bb
to
535da17
Compare
Signed-off-by: tuannn2 <tuan2.nguyennhu@toshiba.co.jp>
535da17
to
e8f6e6b
Compare
Changes looks good. |
Issue: #1979
How To Test?