Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Allow both native build and cross build #5321

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Apr 2, 2019

This commit adds a new flag for cross build in j9.flags, and new spec
files that use the flag for cross build of AArch64 runtime.

Fixes: #5285

Signed-off-by: knn-k konno@jp.ibm.com

@knn-k
Copy link
Contributor Author

knn-k commented Apr 2, 2019

Cross builds call qemu-aarch64 for running constgen and j9ddrgen. (DDR is not enabled for AArch64 yet. See #5221)

The spec files with _cross in their names are enabled by ibmruntimes/openj9-openjdk-jdk11#149.

@knn-k knn-k changed the title AArch64: Allow both native build and cross build WIP: AArch64: Allow both native build and cross build Apr 2, 2019
@knn-k
Copy link
Contributor Author

knn-k commented Apr 2, 2019

I found a problem with cross build with compressed references. Marking with "WIP:" until resolved.

@knn-k knn-k changed the title WIP: AArch64: Allow both native build and cross build AArch64: Allow both native build and cross build Apr 2, 2019
@knn-k
Copy link
Contributor Author

knn-k commented Apr 2, 2019

Updated configure_linux_aarch64.mk, and removed the "WIP:" prefix.

Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangshao0
Copy link
Contributor

Can you please add the issue number to the commit message ?

This commit adds a new flag for cross build in j9.flags, and new spec
files that use the flag for cross build of AArch64 runtime.

Fixes: eclipse-openj9#5285

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Apr 2, 2019

Updated the commit message with the issue number.

@pshipton pshipton merged commit 70c608d into eclipse-openj9:master Apr 3, 2019
@knn-k knn-k deleted the aarch64build16 branch April 3, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants