Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3190] Use OpenTelemetry for tracing (via OpenTracing shim) #3205

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Apr 12, 2022

This is for #3190.

OpenTelemetry is now used for tracing via OpenTracing shim. Traces get exported via the OTLP gRPC Exporter (quarkus-opentelemetry-exporter-otlp). Support for Jaeger context propagation has been kept.

Limitations:

Still to be done:

  • clarify "org.jboss.spec.javax.ws.rs/jboss-jaxrs-api_2.1_spec/2.0.1.Final" license entry (currently marked as restricted)
  • documentation changes

@calohmn calohmn added this to the 2.0.0 milestone Apr 12, 2022
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the reference to Jaeger Client, Apache Thrift and all of its dependencies (if no longer used by other components) from the legal/src/main/resources/legal/NOTICE.md file

…im).

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calohmn calohmn merged commit ad0f629 into eclipse-hono:master Apr 20, 2022
@calohmn calohmn deleted the PR/opentelemetry branch April 20, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants