Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Literals #75

Closed
3 tasks done
asmelko opened this issue Aug 13, 2020 · 2 comments · Fixed by #207
Closed
3 tasks done

Literals #75

asmelko opened this issue Aug 13, 2020 · 2 comments · Fixed by #207
Assignees
@slavek-kucera
Labels
enhancement New feature or request released on @release-1.0.0 released

Comments

@asmelko
Copy link
Contributor

asmelko commented Aug 13, 2020 •
edited by slavek-kucera
Loading

Describe the solution you'd like
In some HLASM programs, literals are used. The current plugin version does not provide any functionality for literals. Also, an attribute reference to a literal causes a diagnostic.

We would like to implement a new feature that will provide all needed functionality to properly evaluate and use HLASM literals.

Acceptance criteria

  • implement literal logic employing already implemented data definition logic
  • add an implementation that allows attribute reference to literals
  • implement LTORG instruction to make the literal feature complete
@asmelko asmelko added the enhancement New feature or request label Aug 13, 2020
SWETAS04 pushed a commit to SWETAS04/che-che4z-lsp-for-hlasm that referenced this issue Feb 17, 2021
@michalbali256
Squashed commit of the following:
3cd0268 
commit be6a1f1339f1dfddd386dae5383adf431745a89b
Merge: eab731a9 86dabe8
Author: Michal Bali <michalbali32@gmail.com>
Date:   Wed Jan 29 10:17:01 2020 +0100

    Merge branch 'master-public-mine' into merged

commit eab731a9f213c80490ce598aae0043cc42332286
Merge: 2b30463f cf2600e
Author: Michal Bali <michalbali32@gmail.com>
Date:   Wed Jan 29 10:16:39 2020 +0100

    Merge remote-tracking branch 'main/master' into merged

commit 2b30463f7b6b9b6e34ef4a13ea8abada9cae95c8
Merge: 965eef13 2271454
Author: Michal Bali <michalbali32@gmail.com>
Date:   Wed Jan 29 10:14:09 2020 +0100

    Merge commit '2271454d0ca21a1bbd8cfeefd920c3ae6b0aa8ce' into merged

    # Conflicts:
    #	cmake/try_filesystem_link.cpp
    #	language_server/src/dap/tcp_handler.cpp
    #	language_server/src/dap/tcp_handler.h
    #	language_server/src/stream_helper.h

commit cf2600e
Author: Marcel Hruska <marcel.hruska@broadcom.com>
Date:   Fri Jan 24 16:35:42 2020 +0100

    Performance Improvements vol.2 (eclipse-che4z#80)

    * preparation for hl test
    * Revert "preparation for hl test"
    This reverts commit 098a08c0fab1c34f65602280de8b517c441e3f2a.
    * merge fix
    * latest pull req suggestions
    * reworked variants to templates
    * lazy documentation loading
    * ajds to lazy documentation
    * changes
    * added tests for server features
    * fixed test paths

commit 82587a0
Author: Michal Bali <michal.bali@broadcom.com>
Date:   Tue Jan 14 10:50:47 2020 +0100

    DAP listen on localhost (eclipse-che4z#79)

commit 04a78d3
Author: Marcel Hruska <marcel.hruska@broadcom.com>
Date:   Fri Jan 10 10:26:50 2020 +0100

    small updates to package.json (eclipse-che4z#77)

commit 9b88837
Author: Zeibura Kathau <zeibura.kathau@broadcom.com>
Date:   Thu Jan 9 11:46:48 2020 +0100

    Readme update (eclipse-che4z#75)

    * Update README.md
    Getting started done
    * Update README.md
    features done
    * CA - Conditional Assembly
    * address comments
    * some edits to "macro tracer config"
    * ### Macro Tracer Configuration done
    * ### External Macro Libraries and COPY Members
    * more to last section
    more clarifications, rescue example case from previous readme
    * renamed HLASM Debug to HLASM Macro tracer
    * remove dupe para
    * Commenting out "todo" bits
    * gifs showing HLASM functionality
    * CA Endevor SCM
    * naming fix
    * move highligting picture
    * Using the Macro Tracer section added - REVIEW NEEDED
    * Update README.md
    final edits to readme
    * Update README.md
    * Update README.md
    adding gifs back
    * uncomment new additions
    * suggestions
    * further suggestions
    * readding
    Readding the bits removed
    * Readme update (eclipse-che4z#72) (eclipse-che4z#76)
    * Fix highlighting gif
    * New gif uploaded

commit 2da634d
Author: Michal Bali <michal.bali@broadcom.com>
Date:   Thu Jan 9 09:56:37 2020 +0100

    Add PR number to build file name (eclipse-che4z#78)

    * artifacts with PR numbers
    * asio version changed for better IP check

commit 3644009
Author: Adam Smelko <adam.smelko@broadcom.com>
Date:   Wed Jan 8 16:46:27 2020 +0100

    Performance (eclipse-che4z#73)

    * got rid of creating new parsers
    * macro reparse reusing one parser
    * fixes
    * opencode parsing reusing one parser
    * partial lookahead without semantic predicates
    * fixes
    * parsers hold ASTs again
    * concat_chain copy, opcode update
    * statement_providers directory
    * opcodes are remembered in cached statements
    * fix
    * resolved_statement_impl holds shared_ptr
    * fixes
    * fixes
    * lexer utf8-32 converter thread local, removed recursion in operand rules, uint8_t to processing_format enum types
    * deferred grammar bug + test
    * version
    * system variable count attribute fix + tests
    * confuscating
@slavek-kucera slavek-kucera mentioned this issue Oct 11, 2021
Closed
@slavek-kucera slavek-kucera self-assigned this Nov 12, 2021
@slavek-kucera slavek-kucera linked a pull request Dec 1, 2021 that will close this issue
feat: Literal support #207
Merged
slavek-kucera added a commit that referenced this issue Dec 10, 2021
@slavek-kucera
feat: Literal support (#207)
44a93f2 
(closes #193, closes #75)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavek-kucera slavek-kucera

Labels
enhancement New feature or request released on @release-1.0.0 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Literal support slavek-kucera/che-che4z-lsp-for-hlasm
2 participants
@slavek-kucera @asmelko