Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid ALIAS operands are marked as errors #157

Closed
michalbali256 opened this issue Aug 12, 2021 · 2 comments · Fixed by #178
Closed

Valid ALIAS operands are marked as errors #157

michalbali256 opened this issue Aug 12, 2021 · 2 comments · Fixed by #178
Assignees
@slavek-kucera
Labels
bug Something isn't working released on @release-0.15.0 released

Comments

@michalbali256
Copy link
Contributor

Describe the bug
Valid ALIAS operands are marked as errors.

https://www.ibm.com/docs/en/zos/2.1.0?topic=statements-alias-instruction

To Reproduce
Write the following program:

 ALIAS C'somestring'
 ALIAS X'4343434343'

Currently, it is marked as 'Bad operand value'.

Expected behavior
No errors.

Platform

  • Editor: Any
  • OS: Any
  • Plugin version: 0.13.0

Additional context
The operands are parsed as self-defining term - as a term of machine instruction. See assembler_operand_rules.g4 and machine_expr_rules. Once parsed as self_def_term, it is immediately checked whether it has 4 and less characters.
@michalbali256 michalbali256 added the bug Something isn't working label Aug 13, 2021
@slavek-kucera slavek-kucera self-assigned this Sep 13, 2021
slavek-kucera added a commit to slavek-kucera/che-che4z-lsp-for-hlasm that referenced this issue Sep 14, 2021
@slavek-kucera
fixes eclipse-che4z#157
8035693
@slavek-kucera slavek-kucera mentioned this issue Sep 14, 2021
Merged
slavek-kucera added a commit to slavek-kucera/che-che4z-lsp-for-hlasm that referenced this issue Sep 14, 2021
@slavek-kucera
fixes eclipse-che4z#157
fa79345
slavek-kucera added a commit that referenced this issue Sep 17, 2021
@slavek-kucera
fix: Remove ALIAS operand parsing limitation (#178)
480e602 
(fixes #157)
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

🎉 This issue has been resolved in version 0.15.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavek-kucera slavek-kucera

Labels
bug Something isn't working released on @release-0.15.0 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove ALIAS operand parsing limitation slavek-kucera/che-che4z-lsp-for-hlasm
2 participants
@michalbali256 @slavek-kucera