This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
[Remote plugins] Call OnDidDeploy only if client is set #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorhun
requested review from
evidolob,
musienko-maxim,
tolusha and
AndrienkoAleksandr
AndrienkoAleksandr
approved these changes
Oct 23, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
crw-ci-test |
olexii4
reviewed
Oct 23, 2019
extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts
Show resolved
Hide resolved
olexii4
approved these changes
Oct 23, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
evidolob
approved these changes
Oct 23, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
benoitf
approved these changes
Oct 23, 2019
|
FYI ci-build check is failing |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
|
Rebased |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
musienko-maxim
approved these changes
Oct 24, 2019
26 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In remote plugins mechanism we send some meta information between main Theia and remote plugin host. This PR provides the fix for the case when client has not connected yet, but we've got a message to send. It is safe to not to send the info, because when client is ready it queries the info itself.
What issues does this PR fix or reference?
eclipse-che/che#14942